Skip to content

use sys.platform in testing to make pre-commit work on windows#5212

Merged
masenf merged 1 commit intomainfrom
use-sys.platform-in-testing
May 8, 2025
Merged

use sys.platform in testing to make pre-commit work on windows#5212
masenf merged 1 commit intomainfrom
use-sys.platform-in-testing

Conversation

@adhami3310
Copy link
Copy Markdown
Member

fixes #2471

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 30, 2025

CodSpeed Performance Report

Merging #5212 will improve performances by 4.17%

Comparing use-sys.platform-in-testing (aa5334c) with main (26f1a7b)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_stateful[_simple_page] 256.5 µs 246.2 µs +4.17%

@masenf masenf merged commit b970aea into main May 8, 2025
42 checks passed
@masenf masenf deleted the use-sys.platform-in-testing branch May 8, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reflex\testing.py is using platform.system, causing pre-commit error for Windows

2 participants